Open
Conversation
vbudovski
force-pushed
the
fix/support-mocked-dates
branch
2 times, most recently
from
3d3c334 to
f09a9f3
Compare
Jest provides two different implementations of fake timers - legacy and modern. The legacy implementation works with RRule, while the modern one does not, as it uses a strict instance check. Compare the toString result of the object if the value is not a Date instance.
vbudovski
force-pushed
the
fix/support-mocked-dates
branch
from
f09a9f3 to
5e96745
Compare
davidgoli
approved these changes
Feb 10, 2023
Collaborator
davidgoli
left a comment
davidgoli
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
| value instanceof Date || | ||
| (typeof value === 'object' && | ||
| Object.prototype.toString.call(value) === '[object Date]') | ||
| ) |
Collaborator
There was a problem hiding this comment.
This looks like the lodash isDate implementation - nice
Collaborator
|
Please resolve the conflicts and I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jest provides two different implementations of fake timers - legacy and modern. The legacy implementation works with
RRule, while the modern one does not, as it uses a strict instance check. Compare the toString result of the object if
the value is not a Date instance.
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing